Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cpu.usage metrics and disable cpu.utilization metrics #855

Merged
merged 3 commits into from
Mar 8, 2024
Merged

feat: Add cpu.usage metrics and disable cpu.utilization metrics #855

merged 3 commits into from
Mar 8, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Mar 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add configuration capabilities for kubeletstatreceiver to enable or disable metrics
  • Disable deprecated *.cpu.utilization metrics
  • Enable *.cpu.usage metrics
  • Update unit and e2e test accordingly new configuration changes

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@hisarbalik hisarbalik requested a review from a team as a code owner March 6, 2024 14:46
@hisarbalik hisarbalik added the area/metrics MetricPipeline label Mar 6, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2024
@hisarbalik hisarbalik added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Mar 6, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2024
@hisarbalik hisarbalik changed the title feat: Add cpu.usage metrics feat: Add cpu.usage metrics and disable cpu.utilization metrics Mar 6, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2024
@hisarbalik hisarbalik removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@rakesh-garimella rakesh-garimella self-assigned this Mar 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 8, 2024
@kyma-bot kyma-bot merged commit de385bf into kyma-project:main Mar 8, 2024
20 checks passed
@a-thaler a-thaler added this to the 1.11.0 milestone Mar 8, 2024
@a-thaler a-thaler added the kind/bug Categorizes issue or PR as related to a bug. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrkl chrkl chrkl approved these changes

Assignees

@chrkl chrkl

@rakesh-garimella rakesh-garimella

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hisarbalik @chrkl @a-thaler @rakesh-garimella @kyma-bot